Define a TelemetryBlob type to hold JSON blobs #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TelemetryBlob type provides helper methods that can be used to validate that provided blobs are: * Valid JSON * JSON objects * Contain a top-level "version" field * Are not too big. The validity of provided JSON blobs is checked when they are received via a Generate() interface. Also update client side item handling to leverage the json.RawMessage type for storing the JSON blobs; this avoid undesirable processing of the provided JSON blob data, which should remain untouched en-route to long term storage in the SUSE Telemetry service. Minor restructuring of the client side library, moving limits to it's own subpackage to avoid an import loop when adding the CheckLimits() helper method to the TelemetryBlob. Fixes: #41, #26
rtamalin
added a commit
to SUSE/telemetry-server
that referenced
this pull request
Aug 2, 2024
Ensure that provided telemetry data JSOB blob data is not processed unless needed, avoiding unmarshaling and re-marshaling of the field. Depends up breaking changes in SUSE/telemetry#42 Fixes: #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TelemetryBlob type provides helper methods that can be used to validate that provided blobs are:
The validity of provided JSON blobs is checked when they are received via a Generate() interface.
Also update client side item handling to leverage the json.RawMessage type for storing the JSON blobs; this avoid undesirable processing of the provided JSON blob data, which should remain untouched en-route to long term storage in the SUSE Telemetry service.
Minor restructuring of the client side library, moving limits to it's own subpackage to avoid an import loop when adding the CheckLimits() helper method to the TelemetryBlob.
Fixes: #41, #26