Skip to content

Commit

Permalink
change language_detection_threshold type to float
Browse files Browse the repository at this point in the history
Cannot be an optional parameter
  • Loading branch information
extrange committed Dec 4, 2024
1 parent 8327d8c commit 5f251c9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion faster_whisper/transcribe.py
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ def transcribe(
clip_timestamps: Union[str, List[float]] = "0",
hallucination_silence_threshold: Optional[float] = None,
hotwords: Optional[str] = None,
language_detection_threshold: Optional[float] = 0.5,
language_detection_threshold: float = 0.5,
language_detection_segments: int = 1,
) -> Tuple[Iterable[Segment], TranscriptionInfo]:
"""Transcribes an input file.
Expand Down
7 changes: 7 additions & 0 deletions tests/test_transcribe.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import os

import numpy as np
import pytest

from faster_whisper import BatchedInferencePipeline, WhisperModel, decode_audio

Expand Down Expand Up @@ -269,3 +270,9 @@ def test_monotonic_timestamps(physcisworks_path):
assert word.start <= word.end
assert word.end <= segments[i].end
assert segments[-1].end <= info.duration


def test_language_detection_threshold_none_raises_error(jfk_path):
model = WhisperModel("tiny")
with pytest.raises(TypeError):
model.transcribe(jfk_path, language_detection_threshold=None) # type: ignore

0 comments on commit 5f251c9

Please sign in to comment.