[SALAD-23967] WebApp: Earning Table - added #1272
Open
+279
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rners01
reviewed
Feb 7, 2025
|
|
||
| const getRows = (): Array<TableRow> => { | ||
| return machines | ||
| .filter((machine) => machine.machine_id) |
There was a problem hiding this comment.
why do we need this filter?
There was a problem hiding this comment.
property machine_id is marked as optional by kioto types. I don't think it's a relevant case, but we should handle it
rners01
reviewed
Feb 7, 2025
Comment on lines
+112
to
+113
| console.log('daysShowing ===> ', daysShowing) | ||
| console.log('earningsPerMachine ===> ', earningsPerMachine) |
There was a problem hiding this comment.
we have temporary keep them to avoid ts errors. Current implementation is partial and we will need this data in future - so no need to remove these props and related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task on hold