Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch translation file from filesystem directly #2053

Draft
wants to merge 1 commit into
base: create-use-app-origin-hook
Choose a base branch
from

Conversation

vmarta
Copy link
Contributor

@vmarta vmarta commented Oct 5, 2024

Related to #2050

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@vmarta vmarta added the wip Work in process label Oct 5, 2024
try {
const file = `${getAppOrigin()}${getAssetUrl(
if (isServerSide && process.env.NODE_ENV === 'production') {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI currently, fetchTranslations is called only on the server side. So this is the if-condition that will be reached.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We called the fetchTranslations from within the App component. See

return fetchTranslations(targetLocale)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant