Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oldap data structure in test #17191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix oldap data structure in test #17191

wants to merge 1 commit into from
+2 −2

Conversation

lhellebr
Copy link
Contributor

No description provided.

@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Dec 17, 2024
@lhellebr lhellebr requested a review from a team as a code owner December 17, 2024 12:51
@lhellebr lhellebr requested a review from a team December 17, 2024 12:51
pondrejk
pondrejk approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, pending test run

@pondrejk
Copy link
Contributor

pondrejk commented Jan 7, 2025

on a second look, I see there are more occurrences of open_ldap_user, shouldn't those be changed too? https://github.com/search?q=repo%3ASatelliteQE%2Frobottelo%20open_ldap_user&type=code

@lhellebr
Copy link
Contributor Author

lhellebr commented Feb 6, 2025

@pondrejk I don't think so, note that settings.open_ldap.open_ldap_user is a different thing from fixture open_ldap_data and it seems one is to be accessed as object with attributes and the other as a dictionary.

@lhellebr
Copy link
Contributor Author

lhellebr commented Feb 6, 2025

trigger: test-robottelo
pytest: tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10109
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource --external-logging
Test Result : ================== 1 failed, 9 warnings in 616.16s (0:10:16) ===================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 6, 2025
@lhellebr
Copy link
Contributor Author

lhellebr commented Feb 6, 2025

trigger: test-robottelo
pytest: tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource

@lhellebr
Copy link
Contributor Author

lhellebr commented Feb 6, 2025 •
edited
Loading

PRT failed with some unrelated-looking UI error. It works locally. Rerunning PRT.

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10110
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource --external-logging
Test Result : ================== 1 failed, 9 warnings in 650.34s (0:10:50) ===================

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10312
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource --external-logging
Test Result : ================== 1 failed, 9 warnings in 703.90s (0:11:43) ===================

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10314
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource --external-logging
Test Result : ================== 1 failed, 9 warnings in 645.84s (0:10:45) ===================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk

Assignees

@lhellebr lhellebr

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lhellebr @pondrejk @Satellite-QE @ogajduse