Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Make the sphinx check more resilient #17739

Merged

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #17701

Just saw an issue in the robottelo CI where this popped up.

  File "/home/runner/work/robottelo/robottelo/robottelo/config/__init__.py", line 25, in get_settings
    if builtins.__sphinx_build__:
       ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'builtins' has no attribute '__sphinx_build__'

If we simply make this a getattr call, then we don't have to worry about that attribute being present.

Just saw an issue in the robottelo CI where this popped up.

  File "/home/runner/work/robottelo/robottelo/robottelo/config/__init__.py", line 25, in get_settings
    if builtins.__sphinx_build__:
       ^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'builtins' has no attribute '__sphinx_build__'

If we simply make this a getattr call, then we don't have to worry about that attribute being present.

(cherry picked from commit ed9a7a0)
@Satellite-QE Satellite-QE requested a review from a team as a code owner March 3, 2025 14:37
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 3, 2025
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo

@ogajduse ogajduse merged commit a5336c6 into 6.15.z Mar 3, 2025
14 of 15 checks passed
@ogajduse ogajduse deleted the cherry-pick-6.15.z-ed9a7a01f0bcd78ebad40855d170a4a4506c5407 branch March 3, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants