Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.17.z] Fix assertion in docker test #17762

Merged
merged 1 commit into from
Mar 5, 2025
Merged

[6.17.z] Fix assertion in docker test #17762

merged 1 commit into from
Mar 5, 2025

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #17728

Problem Statement

Downstream tests were failing due to wrong assertion message. I'm not sure if this also happens on upstream.
If PRT fails I would close the PR.

Solution

Fix assertion message

Tests to run

tests/foreman/api/test_repository.py::TestDockerRepository::test_negative_synchronize_private_registry_no_passwd

@Satellite-QE Satellite-QE requested a review from a team as a code owner March 5, 2025 11:06
@Satellite-QE Satellite-QE added 6.17.z Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Mar 5, 2025
@Satellite-QE
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py::TestDockerRepository::test_negative_synchronize_private_registry_no_passwd

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Mar 5, 2025
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 10404
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py::TestDockerRepository::test_negative_synchronize_private_registry_no_passwd --external-logging
Test Result : ================== 1 passed, 9 warnings in 615.71s (0:10:15) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 5, 2025
@LadislavVasina1 LadislavVasina1 merged commit bf525b4 into 6.17.z Mar 5, 2025
17 of 19 checks passed
@LadislavVasina1 LadislavVasina1 deleted the cherry-pick-6.17.z-defcd6c4183b0d6d741d54f601c9ee30f51b84c9 branch March 5, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosas dosas dosas approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@dosas dosas

Labels
6.17.z Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @dosas @LadislavVasina1