Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake manifest from Robottelo #17808

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

synkd
Copy link
Contributor

@synkd synkd commented Mar 7, 2025

Problem Statement

Satellite QE would like to remove workflows and pipelines associated with the fake manifest from our AAP and Jenkins environments.

Solution

Remove references to and uses of the fake manifest from all Pytest fixtures, helper modules, utilities, and tests.

@synkd synkd requested review from a team as code owners March 7, 2025 17:20
@synkd synkd force-pushed the remove_fake_manifest_from_robottelo branch from 58443c3 to a37bb0e Compare March 7, 2025 17:29
@synkd synkd added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z Framework Changes A modification of the robottelo framework labels Mar 7, 2025
@synkd
Copy link
Contributor Author

synkd commented Mar 7, 2025

trigger: test-robottelo
pytest: tests/foreman/* -k 'test_negative_update_red_hat_repo or test_positive_able_to_disable_and_enable_rhel_repos or test_positive_ansible_job_timeout_to_kill or test_positive_ansible_job_privilege_escalation or test_positive_ansible_job_with_nonexisting_module or test_positive_ansible_job_on_host or test_positive_ansible_job_on_multiple_host or test_positive_ansible_localhost_on_host'

@synkd synkd force-pushed the remove_fake_manifest_from_robottelo branch from a37bb0e to b73573c Compare March 7, 2025 18:51
This PR removes references to and uses of the fake manifest from all
Pytest fixtures, helper modules, utilities, and tests. Doing so will
enable Satellite QE to remove associated workflows and pipelines from
our AAP and Jenkins environments.
@synkd synkd force-pushed the remove_fake_manifest_from_robottelo branch from b73573c to 6828573 Compare March 7, 2025 19:16
@synkd synkd force-pushed the remove_fake_manifest_from_robottelo branch from fb84196 to 80f0191 Compare March 7, 2025 19:38
Comment on lines +101 to +105
with (
function_sca_manifest as manifest,
open(temporary_local_manifest_path, 'wb') as file_handler,
):
file_handler.write(manifest.content)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking alternative

Suggested change
with (
function_sca_manifest as manifest,
open(temporary_local_manifest_path, 'wb') as file_handler,
):
file_handler.write(manifest.content)
with function_sca_manifest as manifest:
Path(temporary_local_manifest_path).write_bytes(manifest.content)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z CherryPick PR needs CherryPick to previous branches Framework Changes A modification of the robottelo framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants