Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facts: Prevent inability to access MSRs from showing availible facts #18

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

andrewjj20
Copy link
Contributor

No description provided.

@andrewjj20 andrewjj20 requested a review from cmouzaoui June 11, 2024 18:23
@andrewjj20 andrewjj20 self-assigned this Jun 11, 2024
Copy link
Collaborator

@cmouzaoui cmouzaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the idea that if we can't access mrs, we still want to be able to print the facts that we do know?

@andrewjj20
Copy link
Contributor Author

is the idea that if we can't access mrs, we still want to be able to print the facts that we do know?

pretty much, print the error message and print what was discovered. It seems more useful to say what can be found than to try and error. I could see adding an option in the future to force a failure when msrs cannot be accessed.

@andrewjj20 andrewjj20 requested a review from cmouzaoui June 11, 2024 23:35
@andrewjj20 andrewjj20 merged commit 3790417 into ScaleComputing:main Jun 12, 2024
4 checks passed
@andrewjj20 andrewjj20 deleted the preventMSRErrorExit branch June 12, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants