The cpu to query can now be specified #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it defaults to zero, which is what was used for MSRs before. for CPUID before tasksel or similar would be needed. It also honors this option
iczerjones
reviewed
Sep 12, 2024
| @@ -18,7 +18,7 @@ pub type Result<V> = std::result::Result<V, Error>; | |||
| impl fmt::Display for Error { | |||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | |||
| match self { | |||
| Error::NotAvailible => write!(f, "MSR Feature not availible"), | |||
| Error::NotAvailible(name) => write!(f, "MSR Feature not availible file: {}", name), | |||
iczerjones
approved these changes
Sep 12, 2024
cmouzaoui
reviewed
Sep 13, 2024
cmouzaoui
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it defaults to zero, which is what was used for MSRs before. for CPUID before tasksel or similar would be needed. It also honors this option