Improve unchained interop
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or any other type that provides a custom `to` conversion that is non trivial. Internal type coercions are now done via `toInternal`.
10 / x where `x` is some non trivial unit (e.g. unchained) did previously remove the unit accidentally.
The concept definition now requires the types to have a `to` conversion. For numbers this is provided here. Also fixes the exponentiation operation if UnitLess and floats are mixed.
If two types are an effective alias, i.e. same type name defined in a different place, it converts m2 to m1's type. This can happen in unchained for locally defined types. Throws a better error message if two types are to be compared that cannot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues when working on Unchained types.
IMPORTANT: You need to update to Unchained version
v0.4.2, which I just tagged.