Skip to content

use session in twilio stream #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

use session in twilio stream #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef59e91
use session in twilio stream
Jul 25, 2025
5c18b01
resolve conflict
Jul 25, 2025
9af4c75
Merge branch 'master' of https://github.com/SciSharp/BotSharp into fe…
Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions src/Plugins/BotSharp.Plugin.ChatHub/ChatStreamMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ private async Task HandleWebSocket(IServiceProvider services, string agentId, st
_session = new BotSharpRealtimeSession(services, webSocket, new ChatSessionOptions
{
Provider = "BotSharp Chat Stream",
BufferSize = 1024 * 16,
JsonOptions = BotSharpOptions.defaultJsonOptions
BufferSize = 1024 * 32,
JsonOptions = BotSharpOptions.defaultJsonOptions,
Logger = _logger
});

var hub = services.GetRequiredService<IRealtimeHub>();
Expand All @@ -79,10 +80,13 @@ private async Task HandleWebSocket(IServiceProvider services, string agentId, st
continue;
}

var (eventType, data) = MapEvents(conn, receivedText);
var (eventType, data) = MapEvents(conn, receivedText, conversationId);
if (eventType == "start")
{
var request = InitRequest(data);
#if DEBUG
_logger.LogCritical($"Start chat stream connection for conversation ({conversationId})");
#endif
var request = InitRequest(data, conversationId);
await ConnectToModel(hub, webSocket, request?.States);
}
else if (eventType == "media")
Expand All @@ -94,6 +98,9 @@ private async Task HandleWebSocket(IServiceProvider services, string agentId, st
}
else if (eventType == "disconnect")
{
#if DEBUG
_logger.LogCritical($"Disconnecting chat stream connection for conversation ({conversationId})");
#endif
await hub.Completer.Disconnect();
break;
}
Expand All @@ -115,11 +122,20 @@ await hub.ConnectToModel(responseToUser: async data =>
}, initStates: states);
}

private (string, string) MapEvents(RealtimeHubConnection conn, string receivedText)
private (string, string) MapEvents(RealtimeHubConnection conn, string receivedText, string conversationId)
{
var response = JsonSerializer.Deserialize<ChatStreamEventResponse>(receivedText);
var data = response?.Body?.Payload ?? string.Empty;
ChatStreamEventResponse? response = new();

try
{
response = JsonSerializer.Deserialize<ChatStreamEventResponse>(receivedText);
}
catch (Exception ex)
{
_logger.LogError(ex, $"Error when deserializing chat stream event response for conversation ({conversationId}) (response: {receivedText?.SubstringMax(30)})");
}

var data = response?.Body?.Payload ?? string.Empty;
switch (response.Event)
{
case "start":
Expand Down Expand Up @@ -157,14 +173,15 @@ private void InitEvents(RealtimeHubConnection conn)
});
}

private ChatStreamRequest? InitRequest(string data)
private ChatStreamRequest? InitRequest(string data, string conversationId)
{
try
{
return JsonSerializer.Deserialize<ChatStreamRequest>(data, BotSharpOptions.defaultJsonOptions);
}
catch
catch (Exception ex)
{
_logger.LogError(ex, $"Error when deserializing initial request data for conversation ({conversationId}).");
return null;
}
}
Expand Down
38 changes: 26 additions & 12 deletions src/Plugins/BotSharp.Plugin.Twilio/TwilioStreamMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
using BotSharp.Abstraction.Hooks;
using BotSharp.Abstraction.MLTasks;
using BotSharp.Abstraction.Options;
using BotSharp.Abstraction.Realtime;
using BotSharp.Abstraction.Realtime.Models;
using BotSharp.Abstraction.Realtime.Models.Session;
using BotSharp.Abstraction.Routing;
using BotSharp.Abstraction.Utilities;
using BotSharp.Core.Session;
using BotSharp.Plugin.Twilio.Interfaces;
using BotSharp.Plugin.Twilio.Models.Stream;
using Microsoft.AspNetCore.Http;
Expand All @@ -20,8 +23,11 @@ public class TwilioStreamMiddleware
{
private readonly RequestDelegate _next;
private readonly ILogger<TwilioStreamMiddleware> _logger;
private BotSharpRealtimeSession _session;

public TwilioStreamMiddleware(RequestDelegate next, ILogger<TwilioStreamMiddleware> logger)
public TwilioStreamMiddleware(
RequestDelegate next,
ILogger<TwilioStreamMiddleware> logger)
{
_next = next;
_logger = logger;
Expand All @@ -46,6 +52,7 @@ public async Task Invoke(HttpContext httpContext)
}
catch (Exception ex)
{
_session?.Dispose();
_logger.LogError(ex, $"Error in WebSocket communication: {ex.Message} for conversation {conversationId}");
}
return;
Expand All @@ -57,33 +64,37 @@ public async Task Invoke(HttpContext httpContext)

private async Task HandleWebSocket(IServiceProvider services, string agentId, string conversationId, WebSocket webSocket)
{
var settings = services.GetRequiredService<RealtimeModelSettings>();
_session?.Dispose();
_session = new BotSharpRealtimeSession(services, webSocket, new ChatSessionOptions
{
Provider = "BotSharp Twilio Stream",
BufferSize = 1024 * 32,
JsonOptions = BotSharpOptions.defaultJsonOptions,
Logger = _logger
});

var hub = services.GetRequiredService<IRealtimeHub>();
var conn = hub.SetHubConnection(conversationId);
conn.CurrentAgentId = agentId;

// load conversation and state
var convService = services.GetRequiredService<IConversationService>();
convService.SetConversationId(conversationId, []);

var hooks = services.GetHooks<ITwilioSessionHook>(agentId);
foreach (var hook in hooks)
{
await hook.OnStreamingStarted(conn);
}

convService.States.Save();

var routing = services.GetRequiredService<IRoutingService>();
routing.Context.Push(agentId);

var buffer = new byte[1024 * 32];
WebSocketReceiveResult result;

do
await foreach (ChatSessionUpdate update in _session.ReceiveUpdatesAsync(CancellationToken.None))
{
Array.Clear(buffer, 0, buffer.Length);
result = await webSocket.ReceiveAsync(new ArraySegment<byte>(buffer), CancellationToken.None);
string receivedText = Encoding.UTF8.GetString(buffer, 0, result.Count);

var receivedText = update?.RawResponse;
if (string.IsNullOrEmpty(receivedText))
{
continue;
Expand Down Expand Up @@ -128,10 +139,13 @@ private async Task HandleWebSocket(IServiceProvider services, string agentId, st
#endif
await hub.Completer.Disconnect();
await HandleUserDisconnected();
break;
}
} while (!result.CloseStatus.HasValue);
}

await webSocket.CloseAsync(result.CloseStatus.Value, result.CloseStatusDescription, CancellationToken.None);
convService.SaveStates();
await _session.DisconnectAsync();
_session.Dispose();
}

private async Task ConnectToModel(IRealtimeHub hub, WebSocket webSocket)
Expand Down
Loading