Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Harmonize grid list css #7619

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[MS] Harmonize grid list css #7619

merged 1 commit into from
Dec 11, 2024

Conversation

fabienSvtr
Copy link
Contributor

Checklist

Before you submit this pull request, please make sure to:

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description
  • Link any dependent pull request in the description

closes #7520

@fabienSvtr fabienSvtr requested a review from a team as a code owner June 19, 2024 09:42
@fabienSvtr fabienSvtr force-pushed the ms-harmonize-list-grid-css branch 3 times, most recently from 021e3fd to 5ff006a Compare June 21, 2024 09:52
@fabienSvtr fabienSvtr force-pushed the ms-harmonize-list-grid-css branch from 5ff006a to a3d93d9 Compare December 2, 2024 08:10
NicoTuxx
NicoTuxx requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@NicoTuxx NicoTuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fail + question about ion-item

@fabienSvtr fabienSvtr force-pushed the ms-harmonize-list-grid-css branch 8 times, most recently from 2aa8ee6 to 6acc888 Compare December 5, 2024 09:56
@fabienSvtr fabienSvtr added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 9, 2024
@fabienSvtr fabienSvtr force-pushed the ms-harmonize-list-grid-css branch from 3c7b047 to 21fabcb Compare December 11, 2024 08:44
@fabienSvtr fabienSvtr enabled auto-merge December 11, 2024 08:44
@fabienSvtr fabienSvtr added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 5302f19 Dec 11, 2024
13 checks passed
@fabienSvtr fabienSvtr deleted the ms-harmonize-list-grid-css branch December 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoTuxx NicoTuxx NicoTuxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harmonize css files for list and grid item
2 participants
@fabienSvtr @NicoTuxx