Simplify Regex type and rename it to PreventSyncPattern
#9049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touilleMan
force-pushed
the
simplify-regex
branch
4 times, most recently
from
d3f86d3
to
424bd3e
Compare
| #[derive(Error, Debug)] | ||
| pub enum PreventSyncPatternError { | ||
| #[error("Regex parsing error: {err}")] | ||
| BadRegex { err: regex::Error }, |
There was a problem hiding this comment.
Use tuple style for error since it only has one value.
That simplify errors handling since we can do
.map_error(PreventSyncPattern::BadRegex)There was a problem hiding this comment.
That's a very good point ! thx
touilleMan
force-pushed
the
simplify-regex
branch
2 times, most recently
from
16794e0
to
ac89683
Compare
AureliaDolo
approved these changes
Dec 2, 2024
| @@ -13,7 +13,7 @@ pub enum ApplyPreventSyncPatternError { | |||
| pub(super) async fn ensure_prevent_sync_pattern_applied_to_wksp( | |||
| storage: &mut WorkspaceStorage, | |||
| device: Arc<LocalDevice>, | |||
| pattern: &Regex, | |||
| pattern: &PreventSyncPattern, | |||
There was a problem hiding this comment.
nit: rename to prevent_sync_pattern for consistency
| self.0.iter().any(|r| r.is_match(string)) | ||
| } | ||
|
|
||
| /// Create an empty regex, that regex will never match anything |
There was a problem hiding this comment.
Suggested change
| /// Create an empty regex, that regex will never match anything | |
| /// Create an empty PreventSyncPattern, that PreventSyncPattern will never match anything |
…s/unit/local_folder_manifest.rs`
…rs` -> `prevent_sync_pattern.rs` in libparsec_types
…start` for extra clarity
…sult}` -> `PreventSyncPattern{Error|Result}`
- Remove useless $ escape code (already handled by `fnmatch_regex`) - Fix panic in libparsec bindings when config contains invalid pattern - Remove parsing from file to simplify API - More consistent naming in methods - Add more tests \o/
touilleMan
force-pushed
the
simplify-regex
branch
from
ac89683
to
c9ffbe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.