Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS] Restyle SidebarMenuPage #9088

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MS] Restyle SidebarMenuPage #9088

wants to merge 2 commits into from

Conversation

fabienSvtr
Copy link
Contributor

@fabienSvtr fabienSvtr commented Dec 2, 2024

Describe your changes

  • Added dropdown feature to toggle visibility
  • Rearranged style
  • Add animation on click
sidebar.mov

Checklist

Before you submit this pull request, please make sure to:

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description
  • Link any dependent pull request in the description

closes #8980
closes #8700

@fabienSvtr fabienSvtr requested a review from a team as a code owner December 2, 2024 16:16
Copy link
Contributor

@NicoTuxx NicoTuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style seems broken for buttons in "manage my organization"

image

Comment on lines +47 to +49
function toggleContent(): void {
isContentVisible.value = !isContentVisible.value;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function toggleContent(): void {
isContentVisible.value = !isContentVisible.value;
}

useless function

lines="none"
class="list-sidebar-header title-h5"
:class="isContentVisible ? 'open' : 'close'"
@click="toggleContent"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@click="toggleContent"
@click="isContentVisible = !isContentVisible"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restyle SidebarMenu Sidebar icons of Workspaces and Favourites buttons not vertically centered
2 participants