Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables HTTPS in Anthias #1940

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Enables HTTPS in Anthias #1940

wants to merge 3 commits into from

Conversation

nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Jun 21, 2024 •
edited
Loading

@vpetersson
Copy link
Contributor

I don't think this is a good idea. Shipping self signed certs goes against most modern best practices. Instead we should probably make an integration with acme.sh and/or Tailscale for getting a real certificate.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nicomiguelino nicomiguelino mentioned this pull request Dec 4, 2024
Open
@nicomiguelino
Copy link
Contributor Author

@vpetersson, I can update this branch and then add a feature that lets users upload their own certificates.
I'm still figuring out how to do the same for devices running BalenaOS.

@vpetersson
Copy link
Contributor

I kinda want something more intelligent. Ideally something that can easily be integrated with Let's Encrypt and/or Tailscale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Anthias
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to HTTPS as the default port binding
2 participants
@nicomiguelino @vpetersson