Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing step in docs for building WebView for Pi 5 #2168

Merged

Conversation

nicomiguelino
Copy link
Contributor

Description

This pull request adds the missing step (where an environment variable named GIT_HASH should be set properly before building and starting the containers) in the documentation for building a WebView binary for Pi 5.

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

@nicomiguelino nicomiguelino marked this pull request as ready for review December 19, 2024 17:51
@nicomiguelino nicomiguelino requested a review from a team as a code owner December 19, 2024 17:51
Copy link
Contributor

@vpetersson vpetersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified with:

GIT_HASH=$(git rev-parse --short HEAD) \
    docker compose -f docker-compose.pi5.yml up -d --build

Since we're not using this anywhere else.

@nicomiguelino nicomiguelino merged commit fadbb3a into Screenly:master Dec 20, 2024
5 checks passed
@nicomiguelino nicomiguelino deleted the update-pi5-webview-build-docs branch December 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants