Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seash helper#runtarget #97

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update seash helper#runtarget #97

wants to merge 3 commits into from

Conversation

Ashmita89
Copy link

The duplicate code is removed

#fix for solving issue  Remove duplicate StartVessel code from seash_helper. #94 in seash repository in Seattle Testbed.
Changes done based on comments from @aaaaalbert to match Seattle Code style guidelines
Code formatting
@aaaaalbert
Copy link
Contributor

Looks good to me. How about factoring out the "AddFileToVessel" complexity as well, and replacing it by a call to upload_target?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants