fix(envoy): add readiness probe to Envoy #5158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
this PR adds a readiness prove to envoy to prevent it from getting traffic while not being able to handle the requests. Primarily this is needed, if the pod starts/restarts.
Which issue(s) this PR fixes:
Fixes #5157
Special notes for your reviewer:
I was first thinking about adding a startup probe for this, but the kubernetes docs state, that this is mostly done for slow starting services and I don't think the envoy is one. On my cluster, the envoy restart/start takes between 10 and 15 seconds so the initial delay of 10 seconds and 3 retries every 5 seconds should be sufficient.
I couldn't see any problems with controller after the health check was added.