fix(metrics): Fix model label metric in case of experiment #6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driev
approved these changes
Nov 28, 2024
sakoush
added a commit
that referenced
this pull request
Dec 2, 2024
* use internal model header to compute model label * add test for rest * add test for grpc rproxy * adjust log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adjusts the metrics label value for
modelto be the actual model name as opposed to the header being passed in the request. Previously using the header in the request means that for experiment, where theseldon-modelheader has a suffix.experiment, can result in ambiguity on which actual model is being actually used.The change in this PR is to use
seldon-model-internalto extract the original model and use it for themodellabel.Which issue(s) this PR fixes:
Fixes INFRA-1278 (internal)
Special notes for your reviewer: