Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(envoy): add an envoy config snapshot test #6121

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

driev
Copy link

@driev driev commented Nov 29, 2024

What this PR does / why we need it:

There is currently no test that checks the generated envoy config. Adding this one, so future changes can be made with some confidence.

Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple of minor comments.

scheduler/pkg/envoy/processor/incremental_test.go Outdated Show resolved Hide resolved
scheduler/pkg/envoy/processor/incremental_test.go Outdated Show resolved Hide resolved
scheduler/pkg/envoy/processor/incremental_test.go Outdated Show resolved Hide resolved
@driev driev merged commit 5a7912a into SeldonIO:v2 Dec 2, 2024
3 checks passed
@driev driev deleted the INFRA-1420/add-snapshot-test branch December 2, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants