-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[grid] UI Overview is able to see live preview per Node #15777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
063644b
to
afba64e
Compare
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
f6776ee
to
06cb579
Compare
User description
🔗 Related Issues
💥 What does this PR do?
Quick live preview of what's happening in Node (main VNC session in Node, it is good for 1 session per Node)
Demo
Screen.Recording.2025-05-22.at.18.29.32.mov
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Add live VNC session preview for each Node in UI
Integrate live session dialog with close and scaling support
Enhance Node component with VNC session detection and controls
Update Overview to pass session data and origin to Node
Changes walkthrough 📝
Node.tsx
Enable live VNC session preview and controls in Node component
javascript/grid-ui/src/components/Node/Node.tsx
Overview.tsx
Pass sessions and origin to Node for live preview
javascript/grid-ui/src/screens/Overview/Overview.tsx