Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lc-531 external video #328

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

typeWolffo
Copy link
Member

@typeWolffo typeWolffo commented Jan 2, 2025

Jira issue(s)

LC-531

Overview

  • added external url handling in "file" lessons

Screenshots

image
image
image
image

@typeWolffo typeWolffo added the review me 👀 PR is ready to be reviewed label Jan 2, 2025
@typeWolffo typeWolffo self-assigned this Jan 2, 2025
@typeWolffo typeWolffo force-pushed the jw_feat_lc-531_external_video_url branch from c6f8942 to cafe4fa Compare January 2, 2025 15:44
},
});

const { reset } = form;

useEffect(() => {
if (lessonToEdit) {
reset({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateuszszczecina removed because reset will return to default values

@typeWolffo typeWolffo marked this pull request as ready for review January 2, 2025 15:51
@typeWolffo typeWolffo force-pushed the jw_feat_lc-531_external_video_url branch from cafe4fa to b9fd0d8 Compare January 2, 2025 16:04
@typeWolffo typeWolffo merged commit 5062e84 into main Jan 3, 2025
3 of 6 checks passed
@typeWolffo typeWolffo deleted the jw_feat_lc-531_external_video_url branch January 3, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me 👀 PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants