New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environments templates #17

Merged

qbart merged 24 commits into main from feat-templates

Jan 10, 2025

Contributor

Jlkan commented Oct 21, 2024

No description provided.

Jlkan added 3 commits

October 21, 2024 13:09


          add templates for: dev, staging, production

5cf2bbb


          fix: name in rds prefix

bce63c1


          add datasource for route53 zone

ac136f5

Jlkan assigned qbart


          chore: Update terraform docs

59d8b9c

Jlkan added the review me 👀 label

Jlkan commented

View reviewed changes

templates/dev/ci.tf Outdated Show resolved Hide resolved

Jlkan commented

View reviewed changes

templates/dev/ecr.tf Outdated Show resolved Hide resolved

Jlkan commented

View reviewed changes

templates/production/ci.tf Outdated Show resolved Hide resolved

Jlkan commented

View reviewed changes

templates/production/cloudfront.tf Outdated Show resolved Hide resolved

Jlkan commented

View reviewed changes

templates/production/ecs.tf Outdated Show resolved Hide resolved

Jlkan commented

View reviewed changes

templates/production/networking.tf Outdated Show resolved Hide resolved

Jlkan commented

View reviewed changes

templates/production/networking.tf Outdated Show resolved Hide resolved

Jlkan commented

View reviewed changes

templates/production/rds.tf Outdated Show resolved Hide resolved

Jlkan commented

View reviewed changes

templates/production/rds.tf Outdated Show resolved Hide resolved


          Update templates/production/rds.tf

cbcc7f0

Jlkan commented

View reviewed changes

templates/production/rds.tf Outdated Show resolved Hide resolved


          Update templates/production/rds.tf

220d667

Jlkan commented

View reviewed changes

templates/production/variables.tf Outdated Show resolved Hide resolved

Jlkan and others added 2 commits

October 23, 2024 10:59


          Update templates/production/variables.tf

900c312


          chore: Update terraform docs

c5e8850

Jlkan commented

View reviewed changes

templates/staging/ci.tf Outdated Show resolved Hide resolved


          Update templates/staging/ci.tf

3e0a3d7

Jlkan commented

View reviewed changes

templates/staging/route53.tf Outdated Show resolved Hide resolved


          Update templates/staging/route53.tf

8aa5086

Jlkan commented

View reviewed changes

templates/staging/variables.tf Outdated Show resolved Hide resolved

Jlkan and others added 2 commits

October 23, 2024 11:02


          Update templates/staging/variables.tf

98fc182


          chore: Update terraform docs

dc989f5

Jlkan commented

View reviewed changes

Contributor Author

Jlkan left a comment

Review


          add changes from review

8743c0d

github-actions bot and others added 5 commits

December 11, 2024 06:22


          chore: Update terraform docs

16261ea


          add new files for dev environment

3cb8842


          chore: Update terraform docs

1450aca


          add new files for dev environment

ccad9c0


          chore: Update terraform docs

edbdd24

Jlkan added the devops 🔧 label

Jlkan assigned Jlkan and qbart and unassigned qbart and Jlkan

qbart reviewed

View reviewed changes

templates/dev/s3.tf Outdated Show resolved Hide resolved

qbart requested changes

View reviewed changes

Member

qbart left a comment

Couple of changes:

All paths should be relative so modules are loaded from local file system (no github)
Make sure there is no random resources for templates - usually moduels handle randomizatio inside
Make sure there is no external project reference names (dm3, or customer related)
Staging and production should contain example of S3 for storing files and default IAM app user that has read/write access to bucket
No need for outputs in templates

templates/staging/ecs.tf Outdated Show resolved Hide resolved

templates/staging/networking.tf Outdated Show resolved Hide resolved

templates/staging/rds.tf Outdated Show resolved Hide resolved

templates/staging/cloudfront.tf Outdated Show resolved Hide resolved

templates/staging/cloudfront.tf Outdated Show resolved Hide resolved

templates/production/rds.tf Outdated Show resolved Hide resolved

templates/dev/secrets.tf Outdated Show resolved Hide resolved

Jlkan and others added 2 commits

January 9, 2025 13:22


          apply feedback

95462b5


          chore: Update terraform docs

e11d85d

Jlkan requested a review from qbart

January 9, 2025 12:26

Jlkan and others added 2 commits

January 9, 2025 13:34


          fix source for modules

c7ad7e5


          chore: Update terraform docs

5eb566c

qbart reviewed

View reviewed changes

templates/dev/iam.tf Outdated Show resolved Hide resolved

qbart requested changes

View reviewed changes

templates/dev/iam.tf Outdated Show resolved Hide resolved

templates/dev/route53.tf Outdated Show resolved Hide resolved

templates/dev/secrets.tf Outdated Show resolved Hide resolved

templates/production/cloudfront.tf Outdated Show resolved Hide resolved

templates/production/networking.tf Outdated Show resolved Hide resolved

templates/staging/cloudfront.tf Outdated Show resolved Hide resolved

templates/staging/networking.tf Outdated Show resolved Hide resolved

Jlkan and others added 2 commits

January 10, 2025 13:42


          apply review

66df856


          chore: Update terraform docs

4480cd7

Jlkan requested a review from qbart

January 10, 2025 12:43

qbart approved these changes

View reviewed changes

qbart merged commit 73e299f into main

qbart deleted the feat-templates branch

January 10, 2025 15:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops 🔧 review me 👀