Cherry-pick "LibWeb: Let determine_the_origin() take an optional URL after all", second commit #25398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally believed that this could never receive a null URL and the spec was inaccurate, but it seems like it can indeed. I don't have a distilled test, but this makes logging in with GitHub work on https://v0.dev/ (cherry picked from commit 1a4b0ded1f802fdcc3ef9b919b5749b086471fc2; amended to also cherry-pick LadybirdBrowser/ladybird#2358)
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally believed that this could never receive a null URL and the spec was inaccurate, but it seems like it can indeed.
I don't have a distilled test, but this makes logging in with GitHub work on https://v0.dev/
(cherry picked from commit 1a4b0ded1f802fdcc3ef9b919b5749b086471fc2; amended to also cherry-pick LadybirdBrowser/ladybird#2358)
LadybirdBrowser/ladybird#1537 (first commit was in #25345).