Advanced features #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ADME, CI, and examples
… updating example and tests accordingly
… collecting USB device information and updating the callback mechanism; remove redundant implementation from serial.cpp
…o examples, and usage guidelines
… enable position-independent code, link libraries statically, and update build steps in CI to use a container image.
…ng installation and build steps into a single command for improved efficiency.
…container for enhanced build capabilities.
…ontainer for improved build compatibility.
Katze719
force-pushed
the
advanced-features
branch
from
c36c1e2 to
bb2e1ce
Compare
…and error handling; remove legacy serial and status_codes headers, and adjust CMake configuration to link cpp_core for improved modularity.
…criptions, error handling examples, and new convenience functions for serial communication, enhancing clarity and usability for developers.
Mqxx
reviewed
Jul 7, 2025
Comment on lines
+27
to
+28
| name: libcpp_unix_bindings | ||
| path: build/libcpp_unix_bindings.so |
There was a problem hiding this comment.
Suggested change
| name: libcpp_unix_bindings | |
| path: build/libcpp_unix_bindings.so | |
| name: bindings_linux | |
| path: build/bindings_linux.so |
Mqxx
requested changes
Jul 7, 2025
| retention-days: 14 | ||
|
|
||
| - name: Attach library to release | ||
| if: github.event_name == 'release' | ||
| uses: softprops/action-gh-release@v1 | ||
| with: | ||
| files: build/libCPP-Unix-Bindings.so | ||
| files: build/libcpp_unix_bindings.so |
There was a problem hiding this comment.
Suggested change
| files: build/libcpp_unix_bindings.so | |
| files: build/bindings_linux.so |
| set(VERSION_PATCH 0) | ||
|
|
||
| set(PROJECT_N CPP-Unix-Bindings) | ||
| set(PROJECT_N cpp_unix_bindings) |
There was a problem hiding this comment.
Suggested change
| set(PROJECT_N cpp_unix_bindings) | |
| set(PROJECT_N cpp_bindings_linux) |
Mqxx
reviewed
Jul 7, 2025
| @@ -1,7 +1,7 @@ | |||
| # CPP-Unix-Bindings | |||
| # cpp_unix_bindings | |||
There was a problem hiding this comment.
Suggested change
| # cpp_unix_bindings | |
| # C++ Bindings Linux |
Mqxx
reviewed
Jul 7, 2025
|
|
||
| A compact C++23 library for talking to serial devices on Linux (e.g. Arduino). | ||
| The project builds a **shared library `libCPP-Unix-Bindings.so`** that can be used via | ||
| The project builds a **shared library `libcpp_unix_bindings.so`** that can be used via |
There was a problem hiding this comment.
Suggested change
| The project builds a **shared library `libcpp_unix_bindings.so`** that can be used via | |
| The project builds a **shared library `bindings_linux.so`** that can be used via |
Mqxx
reviewed
Jul 7, 2025
| @@ -21,7 +21,7 @@ cmake -S . -B build -DCMAKE_BUILD_TYPE=Release | |||
| cmake --build build -j | |||
|
|
|||
| # The resulting library will be located at | |||
| # build/libCPP-Unix-Bindings.so | |||
| # build/libcpp_unix_bindings.so | |||
There was a problem hiding this comment.
Suggested change
| # build/libcpp_unix_bindings.so | |
| # build/bindings_linux.so |
Mqxx
reviewed
Jul 7, 2025
| @@ -36,7 +36,7 @@ Deno ships with a first-class FFI API. | |||
|
|
|||
| ```ts | |||
| // serial_deno.ts | |||
| const lib = Deno.dlopen('./build/libCPP-Unix-Bindings.so', { | |||
| const lib = Deno.dlopen('./build/libcpp_unix_bindings.so', { | |||
There was a problem hiding this comment.
Suggested change
| const lib = Deno.dlopen('./build/libcpp_unix_bindings.so', { | |
| const lib = Deno.dlopen('./build/bindings_linux.so', { |
…dular functions for serial communication, including read, write, and buffer management. Update CMake configuration to exclude serial.cpp and enhance project structure for improved maintainability.
…m 'function' to 'callback_fn' for improved clarity and consistency in naming conventions.
Introduce std::lock_guard to ensure thread-safe access to shared resources in serial communication functions, including buffer management and read/write operations. This change enhances the robustness of the API by preventing data races during concurrent access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.