Bump to Symfony 6.4||7, PHP 8 #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loevgaard
reviewed
Nov 20, 2024
| @@ -0,0 +1,38 @@ | |||
| parameters: | |||
loevgaard
reviewed
Nov 20, 2024
loevgaard
reviewed
Nov 20, 2024
loevgaard
reviewed
Nov 20, 2024
loevgaard
reviewed
Nov 20, 2024
loevgaard
reviewed
Nov 20, 2024
loevgaard
reviewed
Nov 20, 2024
loevgaard
reviewed
Nov 20, 2024
loevgaard
reviewed
Nov 20, 2024
Co-authored-by: Joachim Løvgaard <[email protected]>
Co-authored-by: Joachim Løvgaard <[email protected]>
Co-authored-by: Joachim Løvgaard <[email protected]>
|
Did my "resolve" properly commit your suggestions? At this point, can you accept my PR into a dev branch (2.0?) then make the changes? I'll work off that branch for any more PRs. |
I think it would be best to just make this PR build. Also you haven't made any breaking changes, so no need for a |
You have just resolved my comments, not committed any changes :-) |
|
drat. can you commit your suggestions to my PR?
…On Wed, Nov 20, 2024 at 9:20 AM Joachim Løvgaard ***@***.***> wrote:
Did my "resolve" properly commit your suggestions?
You have just resolved my comments, not committed any changes :-)
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQL4NZMT3DRTZEUYJY32BSLBBAVCNFSM6AAAAABSERUUACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBYG4YDSNBTGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I don't have time for that at the moment, sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs some work, in the test matrix and possible in handling the $request object (the trait was removed).
This should probably be a major version release, since the minimum requirements have changed.