Add some tests

Setono · Mar 3, 2025 · d07046c · d07046c
1 parent 4c86874
commit d07046c
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/src/CronBuilder.php b/src/CronBuilder.php
@@ -121,13 +121,12 @@ public function build(): string
     public static function merge(string $existingCron, self $cronBuilder): string
     {
         $existingCron = trim($existingCron);
+        $cron = $cronBuilder->build();
 
         if ('' === $existingCron) {
-            return $cronBuilder->build();
+            return $cron;
         }
 
-        $cron = $cronBuilder->build();
-
         $replacedCron = preg_replace(
             sprintf(
                 '/%s.*%s/ms',

diff --git a/tests/CronBuilderTest.php b/tests/CronBuilderTest.php
@@ -74,6 +74,34 @@ public function it_merges(): void
         self::assertSame($expected, CronBuilder::merge($existingCrontab, self::getCronBuilder()));
     }
 
+    /**
+     * @test
+     */
+    public function it_does_not_add_the_same_file_twice(): void
+    {
+        $cronBuilder = self::getCronBuilder();
+        $cronBuilder->addFile(__DIR__ . '/cronjobs/jobs.php');
+
+        $expected = <<<CRON
+###> Generated by PHPUnit ###
+0 0 * * * /usr/bin/php /home/johndoe/public_html/12/send-report.php --verbose # Run every day at midnight
+###< Generated by PHPUnit ###
+
+CRON;
+
+        self::assertSame($expected, $cronBuilder->build());
+    }
+
+    /**
+     * @test
+     */
+    public function it_throws_exception_when_jobs_file_does_not_exist(): void
+    {
+        $this->expectException(\InvalidArgumentException::class);
+
+        (new CronBuilder())->addFile(__DIR__ . '/cronjobs/does_not_exist.php');
+    }
+
     /**
      * @test
      *