feature/reset #92
feature/reset #92
Conversation
| @@ -515,7 +531,7 @@ class SelectField extends Component { | |||
| : elementHeight | |||
| */ | |||
| const autoCompleteHeight = this.state.showAutocomplete ? 53 : 0 | |||
| const footerHeight = menuCloseButton ? 36 : 0 | |||
| const footerHeight = (menuCloseButton || menuCancelButton) ? 36 : 0 | |||
There was a problem hiding this comment.
What are the difference(s) between the two ? i smell redundancy...
There was a problem hiding this comment.
One is submiting changes, other is canceling and reseting changes
There was a problem hiding this comment.
OMG, i totally misunderstood you:
- in your original issue, i thought you wanted some button deselecting all selected options, SSF returning an empty value
- but your last comment here sound more like you wish for a canceling button on a per-option basis, ie deselect selected options from some queue, one by one ?
There was a problem hiding this comment.
About deselect all - this is other feature request not implemented here
There was a problem hiding this comment.
Honestly please stay in your issue topic, not in a PR. I think more and more data manipulation is NOT SSF duty, but dev's....
We are currently going into a big environment transfer (see PR). So didnot get time yet to help you with this.
| @@ -427,8 +443,8 @@ class SelectField extends Component { | |||
| const { children, floatingLabel, hintText, hintTextAutocomplete, multiple, disabled, nb2show, | |||
| autocompleteFilter, selectionsRenderer, menuCloseButton, anchorOrigin, canAutoPosition, | |||
| style, menuStyle, elementHeight, innerDivStyle, selectedMenuItemStyle, menuGroupStyle, menuFooterStyle, | |||
| floatingLabelStyle, floatingLabelFocusStyle, underlineStyle, underlineFocusStyle, | |||
| autocompleteUnderlineStyle, autocompleteUnderlineFocusStyle, noMatchFound, noMatchFoundStyle, | |||
| floatingLabelStyle, floatingLabelFocusStyle, underlineStyle, underlineFocusStyle, useLayerForClickAway, | |||
There was a problem hiding this comment.
useLayerForClickAway is a hack, i always wanted to avoid using this ! So big no
There was a problem hiding this comment.
But that is added in your documentation as configurable property. But that was not true, so I fixed that. So you want me to remove that?
There was a problem hiding this comment.
Indeed, you are right. I'll handle that later. Thanks
|
What you mean by closing this pull request? Should I wait for thous features from you or they will never be added? 😰 |
|
Should wait ^^ |
|
Nope. Example needed then :) |
|
At this point I'm going to fork your plugin |
|
Forked version is here https://github.com/moebel-de/material-ui-superselectfield |
Fixes #89 #62 #27 #74