Add configurable default base serve url (clearml#83)

* Added: configurable default base serving url * Changed: chart version bump
Shm013 · Jun 23, 2022 · 6b3aaa3 · 6b3aaa3
1 parent b08a711
commit 6b3aaa3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/charts/clearml-serving/Chart.yaml b/charts/clearml-serving/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: clearml-serving
 description: ClearML Serving Helm Chart
 type: application
-version: 0.3.0
+version: 0.4.0
 appVersion: "0.9.0"
 maintainers:
   - name: valeriano-manassero

diff --git a/charts/clearml-serving/README.md b/charts/clearml-serving/README.md
@@ -1,6 +1,6 @@
 # clearml-serving
 
-![Version: 0.3.0](https://img.shields.io/badge/Version-0.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.9.0](https://img.shields.io/badge/AppVersion-0.9.0-informational?style=flat-square)
+![Version: 0.4.0](https://img.shields.io/badge/Version-0.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.9.0](https://img.shields.io/badge/AppVersion-0.9.0-informational?style=flat-square)
 
 ClearML Serving Helm Chart
 
@@ -23,6 +23,7 @@ ClearML Serving Helm Chart
 | clearml.apiAccessKey | string | `"ClearML API Access Key"` |  |
 | clearml.apiHost | string | `"http://clearml-server-apiserver:8008"` |  |
 | clearml.apiSecretKey | string | `"ClearML API Secret Key"` |  |
+| clearml.defaultBaseServeUrl | string | `"http://127.0.0.1:8080/serve"` |  |
 | clearml.filesHost | string | `"http://clearml-server-fileserver:8081"` |  |
 | clearml.servingTaskId | string | `"ClearML Serving Task ID"` |  |
 | clearml.webHost | string | `"http://clearml-server-webserver:80"` |  |

diff --git a/charts/clearml-serving/templates/clearml-serving-inference-deployment.yaml b/charts/clearml-serving/templates/clearml-serving-inference-deployment.yaml
@@ -35,7 +35,7 @@ spec:
             - name: CLEARML_SERVING_POLL_FREQ
               value: "1.0"
             - name: CLEARML_DEFAULT_BASE_SERVE_URL
-              value: http://127.0.0.1:8080/serve
+              value: "{{ .Values.clearml.defaultBaseServeUrl }}"
             - name: CLEARML_DEFAULT_TRITON_GRPC_ADDR
             {{- if .Values.clearml_serving_triton.enabled }}
               value: "clearml-serving-triton:8001"

diff --git a/charts/clearml-serving/values.yaml b/charts/clearml-serving/values.yaml
@@ -6,6 +6,7 @@ clearml:
   apiHost: http://clearml-server-apiserver:8008
   filesHost: http://clearml-server-fileserver:8081
   webHost: http://clearml-server-webserver:80
+  defaultBaseServeUrl: http://127.0.0.1:8080/serve
   servingTaskId: "ClearML Serving Task ID"
 
 zookeeper: