fix deadlock in dispatch_loop #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix the failing tests. |
|
Closed in favor of #497. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #495
There is a possibility of a deadlock in
dispatch_loop; this issue won't appear on sufficiently fast machines. The workers must be saturated with jobs as a condition for the lock.I tracked down the issue by implementing parts of the CLI and reverted the changes scoping down what was relevant, bisecting style. This is what remained after the process. (It took me 3 days because each reproduction took a lot of time.)
This fixed the issue in my setup.
I don't know a good way to create tests for this, so I created the pull request as-is.