Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten nx graph #5366

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Flatten nx graph #5366

merged 1 commit into from
Feb 18, 2025

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Feb 5, 2025

This PR flattens the NX task graph for lint, test and their variations (e.g. test:coverage)

This makes running these tasks simpler and quicker -- there are no longer any pre-requisite activities. These activities may have been required at one time but as the project has evolved they have become redundant.

Copy link
Contributor Author

shauns commented Feb 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shauns shauns mentioned this pull request Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.57% 9048/11973
🟡 Branches 70.81% 4411/6229
🟡 Functions 75.36% 2373/3149
🟡 Lines 76.08% 8544/11230

Test suite run success

2040 tests passing in 911 suites.

Report generated by 🧪jest coverage report action from aa4285f

@shauns shauns marked this pull request as ready for review February 5, 2025 13:47
@shauns shauns requested review from a team as code owners February 5, 2025 13:47
Base automatically changed from shauns/02-05-drop_test_js_from_cli_kit to main February 18, 2025 10:54
@shauns shauns added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit e08f8d2 Feb 18, 2025
27 checks passed
@shauns shauns deleted the shauns/02-05-flatten_nx_graph branch February 18, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants