Skip to content

FlashList v2 #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 93 commits into from
May 26, 2025
Merged

FlashList v2 #1617

merged 93 commits into from
May 26, 2025

Conversation

naqvitalha
Copy link
Collaborator

Description

This PR adds a new core for new arch that will replace recyclerlistview dependency.

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)


import App from "./src/App";
import { name as appName } from "./app.json";

I18nManager.forceRTL(false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete this?

}
}, [currentStickyIndex, nextStickyIndex, recyclerViewManager, sortedIndices]);

useEffect(() => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naqvitalha Maybe the bug we saw is because the current index is computed in a useEffect instead of a layout effect. This would be computed well after pain right?

@naqvitalha naqvitalha force-pushed the new-rlv-prototype branch from a0439aa to dbe1812 Compare May 26, 2025 22:10
@naqvitalha naqvitalha force-pushed the new-rlv-prototype branch from dbe1812 to af430af Compare May 26, 2025 22:24
@naqvitalha naqvitalha merged commit 5e9a6e0 into main May 26, 2025
10 of 11 checks passed
@naqvitalha naqvitalha added the #gsd:44146 New arch label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:44146 New arch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants