Redirect for i18n handles that don't match #2821
Conversation
Users can interationalize handles in the admin. But the english/default language handle is also still available, even with a internationalized `@inContext` directive. This means duplicate content exists at both: `/de/products/sweatpants` `/de/products/jogginghose` This PR changes the skeleton template implementation to follow what liquid does. If a user hits `/de/products/sweatpants` we'll now 302 redirect to `/de/products/jogginghose`. This also applies to collections, blogs, pages, and articles.
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
|
|
||
| localizedResources.forEach(({handle, data}) => { | ||
| if (handle !== data.handle) { | ||
| url.pathname = url.pathname.replace(handle, data.handle); |
There was a problem hiding this comment.
so .. what happens if you have a product with products handle?
There was a problem hiding this comment.
Yeah, that's an edge case that will break. That's why this code isn't packaged up, and just in the template. The problem here is we don't know how to generate the URL for each resource. So the only way to solve it would be to make the URL a param to the function. But even then, the URL for each of these resources in the template is going to be different based on how they do i18n, which is scaffolded when the project is setup. We don't have an easy way of getting the i18n version of a resource.
To truly solve this problem, we need a more holistic solution to u18n in Hydrogen. This fix is just for an immediate fix, not the bigger i18n solution.
Users can interationalize handles in the admin. But the english/default language handle is also still available, even with a internationalized
@inContextdirective. This means duplicate content exists at both:/de/products/sweatpants/de/products/jogginghoseThis PR changes the skeleton template implementation to follow what liquid does. If a user hits
/de/products/sweatpantswe'll now 302 redirect to/de/products/jogginghose. This also applies to collections, blogs, pages, and articles.Partially resolves https://github.com/Shopify/hydrogen-internal/issues/205
QA instructions
i18nbased on the updated skeleton and based on the hydrogen demostore.http://localhost:3000/de-de/blogs/journal/10-tips-for-better-snowboardingshould redirect tohttp://localhost:3000/de-de/blogs/zeitschrift/10-tipps-fur-besseres-snowboardenChecklist