Supporting remove event in watch. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbutcher
reviewed
Oct 4, 2016
| select { | ||
| case currentEvent = <-events: | ||
| if currentEvent.Op == fsnotify.Chmod { | ||
| if currentEvent.Op&fsnotify.Chmod == fsnotify.Chmod { |
There was a problem hiding this comment.
Typo here, with the placement of &
There was a problem hiding this comment.
Yes it is a bitwise AND, because the OP can be several different ops. You need to check it this way to be acurate. Check this out: https://github.com/fsnotify/fsnotify/blob/master/fsnotify.go#L37
There was a problem hiding this comment.
Actually I think it's just the spacing is off?
There was a problem hiding this comment.
go fmt formats it this way. I have my vim setup so that is formats on save.
There was a problem hiding this comment.
Ah that makes total sense. The spacing is just unusual looking
|
Thanks for clarification on how go fmt formats bitwise operators, TIL. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #159
I made sure that watch now removes files but also touched up the file watcher code to ensure that it will accurately respond to all events that it gets.
cc @chrisbutcher @jessicaxiejw @ilikeorangutans