Fix missing global shopify type for Admin #2493
Conversation
This comment has been minimized.
This comment has been minimized.
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/data-extensions": "0.0.0-snapshot-20241125211200",
"@shopify/ui-extensions": "0.0.0-snapshot-20241125211200",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241125211200" |
|
I'm still getting type 
|
|
The global is now fixed. |
|
/snapit |
vividviolet
force-pushed
the
fix-global
branch
from
ec46466 to
85bd2fe
Compare
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/data-extensions": "0.0.0-snapshot-20241127163639",
"@shopify/ui-extensions": "0.0.0-snapshot-20241127163639",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241127163639" |
vividviolet
force-pushed
the
fix-global
branch
from
ddc97dd to
4f8ebb5
Compare
There was a problem hiding this comment.
I didn't tophat but looks good ✨ I have no idea what le_shopify was and it doesn't exist anywhere. I guess it was a typo 🤷 or the Quebecois API we unshipped 🇨🇦
| // conflicts with build/ts/globals.d.ts | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| const shopify: ShopifyGlobal; |
There was a problem hiding this comment.
You'll also need to patch the checkout-web fork of this file otherwise it might get accidentally reset during our publishing process. This is annoying, sorry 😅
Background
The
shopifyglobal declaration was incorrect all along. With these changes doingshopify.extendinside an extension now works to pick up the types.Try this out by consuming the snapshot build and inside an extension either use the
/// <reference types="@shopify/ui-extensions/admin" />or import theextensionfunction.