Skip to content

Integrated encrypted links functionality, tracking conversions, destination url #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rajpootathar
Copy link
Collaborator

@rajpootathar rajpootathar commented Jun 18, 2025

  • Integrated encrypted links functionality
  • Implemented automatic tracking conversions,
  • destination url returned from handleIntent function

@Copilot Copilot AI review requested due to automatic review settings June 18, 2025 06:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request optimizes the code by cleaning up unused imports, updating constant naming for consistency, and refining log messages for better clarity.

  • Removed an unused import and updated the API URL constant from shortenUrl to baseURL
  • Streamlined sealed class declarations by removing redundant public modifiers
  • Updated README examples to reflect dependency version and logging best practices

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ShortIOSDK/src/main/java/com/github/shortiosdk/ShortIO.kt Updated log tags, replaced shortenUrl with baseURL, and removed an unnecessary import
ShortIOSDK/src/main/java/com/github/shortiosdk/Model/ShortIOResult.kt Removed explicit public visibility for sealed classes and nested classes
ShortIOSDK/src/main/java/com/github/shortiosdk/Model/ShortIOParameters.kt Removed an extraneous blank line
ShortIOSDK/src/main/java/com/github/shortiosdk/Constants.kt Renamed shortenUrl to baseURL for consistency with its usage
README.md Updated dependency version and logging usage in code snippet examples

@rajpootathar rajpootathar changed the title optimized the code Integrated encrypted links functionality and updated the README.md file and optimized the code Jun 27, 2025
@rajpootathar rajpootathar changed the title Integrated encrypted links functionality and updated the README.md file and optimized the code Integrated encrypted links functionality, tracking conversions, destination url Aug 8, 2025
rajpootathar and others added 2 commits August 11, 2025 14:49
included section for conversion tracking with better copy
@rajpootathar rajpootathar marked this pull request as draft August 12, 2025 15:25
@rajpootathar rajpootathar marked this pull request as ready for review August 15, 2025 10:20
@rajpootathar rajpootathar requested a review from gugu August 15, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant