-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace ioutil with os. [-] #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danriedl
Thank you for the contribution.
I have two comments:
- There are other places in the codebase where
ioutil.WriteFile()
is used, could you please adjust them? - I think
1.16
is reasonable as a minimal supported version. Could you please update thegolangci/golangci-lint
to a newer version. This will fix the CI error.
Note: you can run CI on your forked version for testing.
As of the release of Go 1.16 ioutil was deprecated. (go.dev)[https://go.dev/doc/go1.16#ioutil]
Thanks for the review @Shpota . I did fix the other occurence in my fork and did a rebase.
|
19da140
to
90cc478
Compare
Thank you @danriedl. Merged. |
This PR updates the deprecated ioutil module .