Use standard directories

[peterjan]

Uses standard locations for application data instead of the current directory. This brings renterd in line with other system services and makes it easier to manage application data.

Linux, FreeBSD, OpenBSD

• Configuration: /etc/walletd/walletd.yml
• Data directory: /var/lib/walletd

macOS

• Configuration: ~/Library/Application Support/walletd.yml
• Data directory: ~/Library/Application Support/walletd

Windows

• Configuration: %APPDATA%\SiaFoundation\walletd.yml
• Data directory: %APPDATA%\SiaFoundation\walletd

Docker

• Configuration: /data/walletd.yml
• Data directory: /data

[peterjan]

Keeping it in DRAFT until I've tested it but can already be reviewed 👀

[peterjan]

@ChrisSchinnerl @n8maninger the renterd desktop app uses the following folder to store renterd data /Users/peterjan/Library/Application Support/renterd/data while these changes will nudge me towards using /Users/peterjan/Library/Application Support/renterd/... I think ideally those should match and I'm suspecting our other apps will run into the same situation.

[ChrisSchinnerl]

Lgtm so far. Haven't tested it locally yet but will do.

[ChrisSchinnerl]

I'd probably do io.ReadDir and then check if that directory contains anything rather than checking for a specific folder.

[peterjan]

I'll leave this open so Nate sees it. Perhaps he wants to change it on walletd and hostd as well.

[n8maninger]

Checking for anything when it's potentially PWD is not great. That's why I checked specifically for the host/wallet database. Everything else can be rebuilt.

[peterjan]

I've reverted it to check for consensus. I figured it was fine because we merely warn the user. Up for other alternatives but we don't really have the db options since we do SQLite and MySQL.

[ChrisSchinnerl]

Approving but I'd still like to get some feedback from @n8maninger and @alexfreska first before merging this. On the discrepancy between this and the desktop apps.

[n8maninger]

Approving but I'd still like to get some feedback from @n8maninger and @alexfreska first before merging this. On the discrepancy between this and the desktop apps.

We can handle the discrepancy in the desktop apps