Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment.yaml): add an emptyDir volume for /ark/config #51

Closed
wants to merge 3 commits into from
Closed

fix(deployment.yaml): add an emptyDir volume for /ark/config #51

wants to merge 3 commits into from

Conversation

ntrehout
Copy link

With the actual mount, /ark/config is a file instead of a directory.

If we only fix the path to /ark/config/crontab their is permission issues with /ark/config that's why i created an emptyDir

@ntrehout ntrehout requested a review from DrPsychick as a code owner February 24, 2024 12:09
@DrPsychick
Copy link
Collaborator

DrPsychick commented Feb 24, 2024

the base image should create /ark/config if it does not exist:
https://github.com/SickHub/arkserver/blob/8bd05b1c45c1892d51b047e1352ad528ab5c1721/run.sh#L56C1-L58C1

maybe it is enough to add crontab to the mountPath? (not adding an additional volume)
It should, according to docs: https://kubernetes.io/docs/concepts/storage/volumes/#using-subpath

PS: bump the chart version for the GitHub actions to run through.

@ntrehout
Copy link
Author

the base image should create /ark/config if it does not exist:
https://github.com/SickHub/arkserver/blob/8bd05b1c45c1892d51b047e1352ad528ab5c1721/run.sh#L56C1-L58C1

maybe it is enough to add crontab to the mountPath? (not adding an additional volume)
It should, according to docs: https://kubernetes.io/docs/concepts/storage/volumes/#using-subpath

PS: bump the chart version for the GitHub actions to run through.

Hm, the issue is with permission. If we create the volume crontab with the path /ark/config/crontab, the permission of /ark/config are not working with run.sh

@ntrehout
Copy link
Author

I basically tried to copy paste what you've done with the /arkserver, /arkserver/.../Saved etc...

@DrPsychick
Copy link
Collaborator

DrPsychick commented Feb 25, 2024

The support for crontab was never really finished in the base image: https://github.com/SickHub/arkserver/blob/8bd05b1c45c1892d51b047e1352ad528ab5c1721/run.sh#L81C1-L84C1

It would start cron service only when there are uncommented lines in the file.
Do you want to give it a shot and do a PR for the base image? So that one or more lines of crontab can be passed as a environment variable? ${!CRONTAB_@} might help you to identify all env variables starting with CRONTAB_.

see SickHub/arkserver#17

@DrPsychick
Copy link
Collaborator

maybe your issue is fixed with this? #57
There was a bug, mounting crontab as file to /ark/config

@ntrehout ntrehout closed this by deleting the head repository Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants