Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requested updates by CB Lab #19

Closed
wants to merge 2 commits into from
Closed

Conversation

mitre-foss-1
Copy link

Additional FieldMappingTransformation fields were added.

This is the first of a couple new commits by the CB Lab.

@thomaspatzke
Copy link
Member

Hi! Unfortunately I must reject the PR for various reasons:

  • The copyright notice that was added in front of the README only mentions MITRE and their authors, not any of the other contributors. Especially Panos Moullotos who had done lot of improvements in this year was removed from the active maintainers list.
  • The NOTICE part adds further restrictions to the usage beyond the license with reference to some regulations.
  • README content added in the last months was removed.
  • Instructions were added in Getting Started section that are environment-specific (Splunk backend, path names) and wrong (installation with pip instead on sigma plugin install, testing by conversion of rules).
  • No changelog is maintained in the README, this is done in Git commits and releases.
  • The CommandLine mapping is a no-op mapping to itself.
  • A mapping for ProcessId already exists. Furthermore, it refers to the wrong fields, as TargetProcessId is the CrowdStrike-specific process identifier, not the one from the OS.
  • A mapping for sha256 already exists. MD5HashData is always zeroed in the events and shouldn't be used therefore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants