fix: matchParser is called more than once

SimonKagstrom · Oct 10, 2023 · 818d455 · 818d455
1 parent c5d8a32
commit 818d455
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/parser-manager.cc b/src/parser-manager.cc
@@ -27,19 +27,17 @@ class ParserManager: public IParserManager
 		if (!data)
 			return NULL;
 
+		size_t preVal = -1;
 		for (ParserList_t::const_iterator it = m_parsers.begin(); it != m_parsers.end(); ++it)
 		{
 			unsigned int myVal = (*it)->matchParser(fileName, data, sz);
 			if (myVal == match_none)
 				continue;
 
-			if (!best)
-				best = *it;
-
-			unsigned int bestVal = best->matchParser(fileName, data, sz);
-
-			if (myVal > bestVal)
+			if (!best || myVal > preVal) {
 				best = *it;
+				preVal = myVal;
+			}
 		}
 
 		free((void *) data);