Improve kill effect #7148
Improve kill effect #7148
Conversation
| @SuppressWarnings("null") | ||
| private Expression<Entity> entities; | ||
| private boolean IGNORE_TOTEM; |
There was a problem hiding this comment.
| private boolean IGNORE_TOTEM; | |
| private boolean ignoreTotem; |
Efnilite
added
the
bug
| @Since("1.0") | ||
| public class EffKill extends Effect { | ||
|
|
||
| static { | ||
| Skript.registerEffect(EffKill.class, "kill %entities%"); | ||
| Skript.registerEffect(EffKill.class, "kill %entities%", "kill %entities% ignoring [the] (resurrection|revival|[undying] totem|totem [of undying])"); |
There was a problem hiding this comment.
I'm not a huge fan of the syntax. I might prefer to just keep it simple:
ignoring [the|any] totem[s] [of undying]
I'd like to see what others think too though
There was a problem hiding this comment.
What me and others have discussed on discord, is that the kill effect should be recoded to actually kill, since as of right now, it really just feels like a hardcoded damage effect. Another point is that the vanilla /kill command ignores the totem, whereas this, it does not ignore the totem.
There was a problem hiding this comment.
Pickle is talking about the pattern being overly complex, not about it's behavior.
There was a problem hiding this comment.
personally i think ignoring [the|any] totem[s] of undying should be it, as ignoring totems sounds too ambiguous imo
| "kill all endermen, witches and bats", | ||
| "kill the player ignoring totem of undying", | ||
| "kill target entity ignoring the totem", | ||
| "kill target player ignoring resurrection"}) | ||
| @Since("1.0") |
There was a problem hiding this comment.
| @Since("1.0") | |
| @Since("1.0, INSERT VERSION (ignoring totem of undying)") |
| @Since("1.0") | ||
| public class EffKill extends Effect { | ||
|
|
||
| static { | ||
| Skript.registerEffect(EffKill.class, "kill %entities%"); | ||
| Skript.registerEffect(EffKill.class, "kill %entities%", "kill %entities% ignoring [the] (resurrection|revival|[undying] totem|totem [of undying])"); |
There was a problem hiding this comment.
personally i think ignoring [the|any] totem[s] of undying should be it, as ignoring totems sounds too ambiguous imo
Description
This simply improves the kill effect by adding an option to prevent totems from popping
Target Minecraft Versions: any
Requirements: none
Related Issues: none