Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Timespan #7189

Open
wants to merge 12 commits into
base: dev/feature
Choose a base branch
from
Open

Update Timespan #7189

wants to merge 12 commits into from

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Nov 3, 2024 •
edited
Loading

Description

  • Reformats Timespan class to match code standards
    • Moved statics to the top of the class
    • Moved nested class to the bottom
  • Removes @ScheduledForRemoval and replaced with @Deprecated(forRemoval = true)
  • Removes all usages of the "marked for removal"-methods

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the housekeeping Housekeeping-related issue or task. label Nov 3, 2024
sovdeeth
sovdeeth approved these changes Nov 15, 2024
View reviewed changes
src/main/java/ch/njol/skript/util/Timespan.java
Comment on lines -260 to +196
* @param time The time of the requested TimePeriod
* @param time The time of the requested TimePeriod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud

Assignees
No one assigned
Labels
feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. housekeeping Housekeeping-related issue or task.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Efnilite @sovdeeth @Moderocky