Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when pausing is enabled #7228

Open
wants to merge 3 commits into
base: dev/feature
Choose a base branch
from

Conversation

Asleeepp
Copy link
Contributor

@Asleeepp Asleeepp commented Nov 25, 2024

Description

Minecraft recently added a feature where the server "pauses" when no players are online for a while, which disables world and entity ticking until a player comes back. This sounds good in theory, but can really mess with what plugins may expect when no players are online, it may also cause some saving/loading issues, which is why it's for the best to add a warning about pausing in the plugin.

Read more about what paper said about it here

(This also had to be directed to dev/feature because dev/patch isnt updated to 1.21.3)


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth
Copy link
Member

I don't think we should be changing this for server owners; they should choose whether their server allows it or not.

Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be changing values like this automatically.

@Asleeepp Asleeepp changed the title Disable Pausing Add warning when pausing is enabled Nov 25, 2024
@ShaneBeee
Copy link
Contributor

ShaneBeee commented Nov 25, 2024

Might be a good idea to add a condition to check if the server is paused:
https://jd.papermc.io/paper/1.21.3/org/bukkit/Server.html#isPaused()
This could be helpful before running some code.

Maybe also allow them to enable/disable pausing:
https://jd.papermc.io/paper/1.21.3/org/bukkit/Server.html#allowPausing(org.bukkit.plugin.Plugin,boolean)

Note: I believe both of these are Paper specific

@Asleeepp
Copy link
Contributor Author

Might be a good idea to add a condition to check if the server is paused: https://jd.papermc.io/paper/1.21.3/org/bukkit/Server.html#isPaused() This could be helpful before running some code.

Maybe also allow them to enable/disable pausing: https://jd.papermc.io/paper/1.21.3/org/bukkit/Server.html#allowPausing(org.bukkit.plugin.Plugin,boolean)

Note: I believe both of these are Paper specific

uhhh, sure i guess? Not sure i can make tests for them so I guess they'll just have to be just effect and condition

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Nov 26, 2024
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether I'm happy with a warning at all (when there's nothing necessarily wrong with this feature unless it's misused) but I'll approve it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants