-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning when pausing is enabled #7228
base: dev/feature
Are you sure you want to change the base?
Add warning when pausing is enabled #7228
Conversation
I don't think we should be changing this for server owners; they should choose whether their server allows it or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be changing values like this automatically.
Co-authored-by: sovdee <[email protected]>
Might be a good idea to add a condition to check if the server is paused: Maybe also allow them to enable/disable pausing: Note: I believe both of these are Paper specific |
uhhh, sure i guess? Not sure i can make tests for them so I guess they'll just have to be just effect and condition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know whether I'm happy with a warning at all (when there's nothing necessarily wrong with this feature unless it's misused) but I'll approve it anyway.
Description
Minecraft recently added a feature where the server "pauses" when no players are online for a while, which disables world and entity ticking until a player comes back. This sounds good in theory, but can really mess with what plugins may expect when no players are online, it may also cause some saving/loading issues, which is why it's for the best to add a warning about pausing in the plugin.
Read more about what paper said about it here
(This also had to be directed to dev/feature because dev/patch isnt updated to 1.21.3)
Target Minecraft Versions: any
Requirements: none
Related Issues: none