Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add backwards-compatible Getter methods to EventValues #7382

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Re-add backwards-compatible Getter methods to EventValues #7382

merged 6 commits into from
Jan 7, 2025

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Jan 3, 2025 •
edited
Loading

Description

  • Re-adds public Getter methods to EventValues to ensure backwards compatibility.
    • These have been deprecated for removal.
    • The returned Getters are just wrapping the returned Converter, visible in #toGetter.
  • All method names have been updated as well, to accurately reflect that they return Converters now.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jan 3, 2025
@Efnilite Efnilite added the 2.10 Targeting a 2.10.X version release label Jan 3, 2025
@Moderocky Moderocky added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jan 5, 2025
@Moderocky Moderocky merged commit 34a0bc6 into SkriptLang:dev/feature Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moderocky Moderocky Moderocky approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

Assignees
No one assigned
Labels
2.10 Targeting a 2.10.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Efnilite @sovdeeth @Moderocky