SkriptCommand - fix test command again #7390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
Jan 5, 2025
sovdeeth
added
bug
TheAbsolutionism
approved these changes
Jan 5, 2025
APickledWalrus
approved these changes
Jan 5, 2025
Moderocky
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the
/sk testcommand yet again.I recently realized the tab completion worked, but I was not able to actually test just one file/folder, it kept saying said file didnt exist.
I then looked over the code and realized I never actually passed the directory thru when looking for said script.
(its a mystery 🧐 how I never caught this before)
I had to add another method to allow passing the directory thru without breaking previous methods.
I also fixed an issue where the
/sk test/reloadcommands both showed the same directories/files.Now it will show the correct directories whether you're running reload or test.
Target Minecraft Versions: any
Requirements: none
Related Issues: none