-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests - update test command to show failures #7400
Open
ShaneBeee
wants to merge
11
commits into
SkriptLang:dev/feature
Choose a base branch
from
ShaneBeee:shane/more-test-updates
base: dev/feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tests - update test command to show failures #7400
ShaneBeee
wants to merge
11
commits into
SkriptLang:dev/feature
from
ShaneBeee:shane/more-test-updates
+82
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAbsolutionism
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I very much like this!
TheLimeGlass
approved these changes
Jan 6, 2025
cheeezburga
approved these changes
Jan 7, 2025
cheeezburga
added
the
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
label
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the
/sk test
command that doesn't show failed tests.NOTE:
Im not 100% sure this is the best way to do things, so Im open to feedback.
Part One:
When running
/sk test something
, it would show a test as passed even though there was a parse error.Exhibit A:
Now you might be thinking "But Shane, you can see the error right there"
Yes, that is true, but if you run a bunch of tests, not as easy to see.
Also, it still shows the test as a pass, but in reality it didn't pass.
Exhibit B:
"Yay everything looks good...."
"Well, I shouldn't have scrolled up.
So to fix this, I created a custom log handler for testing, TestingLogHandler, and added in some stuff to actually log the parse errors for the tests.
Exhibit C:
"Yay, now I know my test[s] failed"
This also fixes them not showing up in the json file.
Part Two:
A lovely side effect of this test is that it also helps users easily spot parsing errors.
These were run with quickTest
BEFORE:
"What? Where are these errors? I need details 😢"
AFTER:
"Omg there it is... test... script... line and all, oh happy day 😃"
Part Three:
I gave the lists some hyphens, to make them look like lists, and add "none" when said list is empty.
Part Four:
This one is small:
}, TestMode.DEV_MODE ? 0 : 50);
Remove the delay starting the test environment if in DEV_MODE!
Target Minecraft Versions: any
Requirements: none
Related Issues: #7399