Sanity check #20
Merged
Sanity check #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apologies to anyone that ran into this.
(Yoinked from <SlimeVR/SlimeVR-OpenVR-Driver#44>)
GetAction aborts on failure HandleDigitalActionBool prints the name of the failing action.
Mostly caused by vcpkg update, but I also recently tried to pass an optional directly and that didn't work.
At least this was caught before I actually ended up doing a release? >_>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using this as a branch I could push to without touching main, since I hadn't touched this project in ~1 year.
In that time, there was a little bit of bitrot on the windows CI side of things, that has been fixed by bumping the version of vcpkg and the run-vcpkg action.
Also looks in the extra socket directories that have been defined for linux.