Don't filter non-temporal trackers #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
added
Type: Bug
Eirenliel
approved these changes
Dec 7, 2024
|
@Erimelowo can u check this pls |
Erimelowo
requested changes
Dec 8, 2024
server/core/src/main/java/dev/slimevr/tracking/trackers/Tracker.kt
Outdated
Show resolved
Hide resolved
server/core/src/main/java/dev/slimevr/tracking/trackers/Tracker.kt
Outdated
Show resolved
Hide resolved
ButterscotchV
changed the title
ButterscotchV
changed the title
|
@Erimelowo can you recheck it please? |
ButterscotchV
changed the title
|
Once again changing how this PR works lol, I think this is the safest way of doing this, just a simple added flag and it explains what it's for in the comment :3 |
ImUrX
approved these changes
Dec 21, 2024
Eirenliel
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke AutoBone, we should not modify the rotation from it, though this may not be desired depending on what we want to define computed trackers as.